Page 1 of 1
[Fixed] nuemailer.php fix
Posted: Sun Dec 06, 2020 7:05 am
by apmuthu
Please pull in the
fix for
nuemailer.php file from my fork of the repo. I maintain the fixes in a separate folder so as to keep track of the upstream repo independently.
Re: nuemailer.php fix
Posted: Sun Dec 06, 2020 8:03 am
by kev1n
Hi,
What exactly was fixed here?
I just noted that
is now assigned to a new variable, eliminating a redundany.
Re: nuemailer.php fix
Posted: Sun Dec 06, 2020 1:15 pm
by apmuthu
PHP 5.4.27 on XAMPP v1.8.2.5 gave the error that a function cannot be used in a return value in write context and hence the workaround.
Other workarounds suggest to use "!" instead of "empty" as in:
https://stackoverflow.com/questions/153 ... te-context
and
https://mycyberuniverse.com/how-fix-can ... ntext.html
but I found my way easy to do, understand and also avoid redundancy too.
Re: nuemailer.php fix
Posted: Sun Dec 06, 2020 1:17 pm
by kev1n
Got it, thanks for the clarification !
Re: nuemailer.php fix
Posted: Fri Dec 11, 2020 8:57 am
by kev1n
FYI, your fix will soon be included. Thanks again for that!
Re: nuemailer.php fix
Posted: Sun Feb 07, 2021 9:52 pm
by apmuthu
Fixed as of 2021-12-06 by
commit in v4.5