Page 1 of 2

Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sat Mar 10, 2018 4:43 pm
by tonyd
Is there a CSS fix for this issue? Works fine with Google Chrome and Microsoft Edge.

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sat Mar 10, 2018 6:15 pm
by toms
To fix that, edit nuselect.php and add an event parameter to these three handlers.

Code: Select all

        $(document).mousemove(function(event){
            nuMove(event);
        });
        $(document).mousedown(function(event){
            nuDown(event);
        });
        $(document).mouseup(function(event){
            nuUp(event);
        });
WebKit follows IE's old behavior of using a global symbol for "event", but Firefox doesn't.

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sat Mar 10, 2018 6:24 pm
by toms
...and patch nuselectclass.js:

Replace event with e

Code: Select all

function nuUp(e){

	var el						= $(e.target);
	
	if(el.hasClass('nuTableName')){

		window.nuY	= parseInt($(e.target).parent().css('top'));
		window.nuX	= parseInt($(e.target).parent().css('left'));

	}

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sat Mar 10, 2018 6:29 pm
by admin
TonyD,

I have put the fix on Github.

Steven

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sat Mar 10, 2018 9:10 pm
by tonyd
Works great, Steven . . . however . . . now the doubleclick on the join lines(to change the join type) does not work in any browser.

Also, the Resize slider does not work in Firefox.

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sun Mar 11, 2018 1:41 am
by admin
TonyD,

I have fixed those things now - I believe.

You'll need the latest from Github and you'll need to run Update.

Let me know if it works for you.

Steven

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sun Mar 11, 2018 2:44 am
by tonyd
Everything looks like it is working the same for all browsers now. There remains a couple of idiosyncrasies, like the join lines do not redraw correctly when you "Resize" the SQL Builder. Also, resizing seems to center on the frame, which can leave a large gap between the first table and the left side. Both of these I can definitely live with. :D

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sun Mar 11, 2018 4:29 am
by admin
TonyD,

Mate, get over it.

Steven

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sun Mar 11, 2018 10:36 pm
by admin
TonyD,

Sorry about that.

I see your problem now.

Steven

Re: Cannot Drag Tables in SQL Builder using Firefox v58

Posted: Sun Mar 11, 2018 11:48 pm
by admin
TonyD,

I have had to reverse those changes - because of the problems you mentioned.

Sorry about that.

You will need the latest from Github and you'll need to run Update.

You might have to steer away from Firefox for the time being.

Steven