nuMessage left position (2)

[toms]

Hi,

Referring to https://forums.nubuilder.cloud/viewtopic.php?f=19&t=9501

With the latest commit, the change has been reverted

screen_widths.png

[admin]

toms,

Yes, I found some problems with it.

Steven

[toms]

What kind of problems? Maybe I can help you fix it.

[admin]

toms,

If a user tries to open a Form that contains another Form - that they don't have access to.

The warning can be off the left side of the screen...

noaccess.png

Steven

[toms]

I see two possibilities:

1. Center over the parent window:

Code: Select all

l = ( $(window.parent.document).width() - widest) / 2;

This will also work if there is no parent window. If a window does not have a parent, its parent property is a reference to itself.

Maybe add this fix as well: if l < 0, set l = 0

Code: Select all

l = Math.min(0, ( $(window.parent.document).width() - widest) / 2);

2. Center over the top window

Code: Select all

l = ( $(window.top.document).width() - widest) / 2;

This property is especially useful when you are dealing with a window that is in a subframe of a parent or parents, and you want to get to the top-level frameset.

I think 2) is the better option since we can have nested forms (form opens iframe, then again iframe etc.)

[admin]

toms,

OK, that's now on Github - thanks.

Steven

[toms]

Thanks Steven!

[admin]

.